MDEV-38264: Fix failed assertion in json_find_path with trailing commas#4733
Open
abhishek593 wants to merge 1 commit intoMariaDB:10.11from
Open
MDEV-38264: Fix failed assertion in json_find_path with trailing commas#4733abhishek593 wants to merge 1 commit intoMariaDB:10.11from
abhishek593 wants to merge 1 commit intoMariaDB:10.11from
Conversation
grooverdan
added
the
External Contribution
grooverdan
reviewed
Mar 5, 2026
mysql-test/main/func_json.test
Outdated
| SELECT JSON_VALUE('{"a":[1,2]}', '$.a[*]'); | ||
|
|
||
| --echo # End of 10.11 Test | ||
|
|
Member
There was a problem hiding this comment.
note test should be above the line above.
The function json_skip_array_and_count() was trapping syntax errors (e.g., trailing commas) in a local engine copy. Because the error state wasn't propagated back to the main engine, json_find_path() would proceed with an inconsistent state, eventually triggering an assertion failure. This patch ensures that any error encountered during the lookahead scan is propagated to the primary engine. This allows the parser to fail gracefully with a syntax error instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function json_skip_array_and_count() was trapping syntax errors (e.g., trailing commas) in a local engine copy. Because the error state wasn't propagated back to the main engine, json_find_path() would proceed with an inconsistent state, eventually triggering an assertion failure. This patch ensures that any error encountered during the lookahead scan is propagated to the primary engine. This allows the parser to fail gracefully with a syntax error instead of crashing.
Changes: