Open
Conversation
Signed-off-by: Frederic Descamps <lefred@mariadb.org>
|
|
grooverdan
added
the
MariaDB Foundation
grooverdan
requested changes
Mar 5, 2026
Member
grooverdan
left a comment
grooverdan
left a comment
There was a problem hiding this comment.
Welcome @lefred.
Lets get a MDEV written, and some additional strictness with the UUID standards for a UUID_VERSION (which is pretty close to to what user's might expect a UUID_VALID function to perform).
| "uuid_version", // plugin name | ||
| "lefred", // plugin author | ||
| "Function UUID_VERSION()", // the plugin description | ||
| PLUGIN_LICENSE_GPL, // the plugin license (see include/mysql/plugin.h) |
Member
There was a problem hiding this comment.
sigh, not your fault, but we should fix the fact that "GPL" isn't a license.
Author
There was a problem hiding this comment.
I don't really know what to use there then?
Member
There was a problem hiding this comment.
Leave it for now, it needs to be addressed at a higher level.
Member
|
And correct Windows compiling error |
Signed-off-by: Frederic Descamps <lefred@mariadb.org>
Signed-off-by: Frederic Descamps <lefred@mariadb.org>
Signed-off-by: Frederic Descamps <lefred@mariadb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds uuid_version() function to uuid type