(COMPLETED) WM5 | Marcus Zagorski | TV-Show-Library |#4
(COMPLETED) WM5 | Marcus Zagorski | TV-Show-Library |#4MarcusZagorski wants to merge 4 commits intomainfrom
Conversation
✅ Deploy Preview for cyf-marcuszagorski-tv ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adniyaYousaf
left a comment
adniyaYousaf
left a comment
There was a problem hiding this comment.
Well done Marcus! I like your TV show layout and design.
adniyaYousaf
left a comment
adniyaYousaf
left a comment
There was a problem hiding this comment.
I think it would be more user-friendly if there was a Home button available to easily navigate back to the main page after selecting a show from the list. Otherwise, it looks great!!
nirmeet-baweja
left a comment
nirmeet-baweja
left a comment
There was a problem hiding this comment.
Well done! Its great to see your progress in the course and to see it reflected in your code as well. 🎉
| @@ -9,12 +9,12 @@ | |||
| </head> | |||
|
|
|||
| <body> | |||
There was a problem hiding this comment.
I would suggest giving your app a name or a main heading. So that when a user navigates to your website, they know the goal / purpose of the website. But nice page design and layout! Well done there.
| function setup() { | ||
| const allEpisodes = getAllEpisodes(); | ||
| makePageForEpisodes(allEpisodes); | ||
| const currentState = { |
There was a problem hiding this comment.
It is a nice idea to use a single object to keep track of all the states that you need.
| let layoutSelector = document.querySelector(".layout"); | ||
|
|
||
| // Fetch API function to fetch data upon call | ||
| async function fetchAPI(url) { |
There was a problem hiding this comment.
Good job on breaking down the code into small functions.
| } | ||
|
|
||
| // Fetches shows data via API | ||
| async function getAllShows() { |
There was a problem hiding this comment.
What happens if the code fails to fetch the shows? Is the user informed about the failed action in any way?
| } | ||
|
|
||
| async function getAllEpisodes() { | ||
| try { |
There was a problem hiding this comment.
Same comment as above. Is the user kept updated with the state of the website?
| function createEpisodeCard(episode) { | ||
| const layoutSelector = document.querySelector(".layout"); | ||
|
|
||
| const linkCardsToTVMaze = createElement("a", ""); |
There was a problem hiding this comment.
Is it good use of semantic html to have a section tag within ana tag?
| } | ||
| } | ||
|
|
||
| function dropDownAfterSearch(currentShows) { |
| searchLayout.appendChild(displayingFilterResults); | ||
| } | ||
|
|
||
| async function searchFilterEpisodes() { |
There was a problem hiding this comment.
I was unable to use the filter episodes feature. When I navigate to the episodes page for a certain show and type something in the search field, the page takes me back to the search results for shows instead.
| addCardLayout(); | ||
| clearCards(); | ||
| makePageForEpisodes(currentState.allEpisodes); | ||
| currentState.episodesFetched = false; |
There was a problem hiding this comment.
Why is currentState.episodesFetched set to false after the episodes are being fetched?
| rootElem.textContent = `Got ${episodeList.length} episode(s)`; | ||
| async function render() { | ||
| try { | ||
| await getAllShows().then((allEpisodes) => { |
There was a problem hiding this comment.
Are we working with a list of shows or with a list of episodes in this part of the code?
3 participants
Here is my complete TV Show-Library. I hope you enjoy 😊