Relations and services point to each other

[senhalil]

• Prevent uninitialized has_many objects (e.g. vrp.services, vrp.relations, vehicle.rests, etc.) returning a different empty array object with each call
• Instead of ids, use actual references inside the relations and vice versa

[senhalil]

Converted to draft because some tests are broken on Travis after I added the vehicle part as we discussed this morning.

It looks like there are vehicle ids in the relation[:linked_vehicle_ids] list which does not exist. I am not sure if it is broken test logic or a bug due to the location of "expansion" of vehicle trips..

Gonna check next week.

[senhalil]

Moved vehicle-relation references to #146 since it needs a change in the multi-tour expansion location but the relation-service references are good to go.

[fonsecadeline]

@senhalil are you talking about multitour expansion from multitrips.expand ? I think we talked about moving this expand within vrp.create but I can not find related comments.

[senhalil]

@senhalil are you talking about multitour expansion from multitrips.expand ? I think we talked about moving this expand within vrp.create but I can not find related comments.

Yes, I was referring to MultiTrips::expand. Maybe we talked it at the daily point, I don't remember.

Once that function is moved to the beginning of vrp.create -- before the "vrp.send"s -- we can go ahead with the other PR (#146) at the moment creation of relations poses problem because the vehicles "don't exist" from the point of view of base.rb.

[fonsecadeline]

I see, I will work on this expand move as soon as #142 and #143 are merged (prerequisits for multi tour dev)