Skip to content

Add interrupt-unavailable castbar fill color option#43

Open
Reveax wants to merge 2 commits into
Mapkov2:mainfrom
Reveax:feature/interrupt-unavailable-castbar-color
Open

Add interrupt-unavailable castbar fill color option#43
Reveax wants to merge 2 commits into
Mapkov2:mainfrom
Reveax:feature/interrupt-unavailable-castbar-color

Conversation

@Reveax

@Reveax Reveax commented May 26, 2026

Copy link
Copy Markdown

Adds an optional castbar fill tint for target, focus, and boss casts when the player’s own interrupt is unavailable. The tint uses a configurable color from Colors > Castbar Colors and updates back mid-cast when the interrupt becomes available again.

Changes

  • Added Recolor cast fill when interrupt is unavailable under Global Style > Castbar > Interrupt Ready Indicator.
  • Added Interrupt unavailable cast color under Colors > Castbar Colors.
  • Wired the setting through defaults, profile import/export, search, and color APIs.
  • Extended castbar tinting to use the unavailable color through the existing secret-safe C-side color selection path.
  • Added active-cast tracking so cooldown flips repaint target/focus/boss castbars without adding idle OnUpdate work.
  • Kept cooldown event registration scoped to active castbars that need interrupt-ready or fill-tint refreshes.

@Mapkov2

Mapkov2 commented May 27, 2026

Copy link
Copy Markdown
Owner

The feature already exists so I don't see the point of this or other then feature bloat

@Reveax

Reveax commented May 27, 2026

Copy link
Copy Markdown
Author

Yeah that's fair. I understand the concern and too was a bit hesitant about it. Personally it completes the last piece of customization so the interrupt bar is consistent across the different contexts I have it in, but I also get your point. Up to you in the end of course, but I thought instead of maintaining it for just personal use, some people could also be interested with the same thought as me.

@Mapkov2

Mapkov2 commented May 27, 2026

Copy link
Copy Markdown
Owner

If you can do the PR for the main branch incooperate it into the current interrupt indicator as option via drop-down in the castbar menu and move the the color options to the respected color Menu yes I'll add it. Sorry if this came across as a bit harsh. Ty for feedback

@Reveax

Reveax commented May 27, 2026

Copy link
Copy Markdown
Author

Don't worry about it, nothing was interpreted as harsh :)
So im happy todo the changes, to clarify, you mean moving it as an option for "Indicator Style" into the dropdown and wiring the color option into the "Interrupt Ready Indicator" section in castbar colors?

@Mapkov2

Mapkov2 commented May 27, 2026

Copy link
Copy Markdown
Owner

I have a dedicated interrupt indicator section in castbars menu. So backend what you want is already in so you just need to configure your styling of it.

@Reveax

Reveax commented May 27, 2026

Copy link
Copy Markdown
Author
image image

Now sits as an indicator style option with its color respectively in the section.

@Mapkov2

Mapkov2 commented May 27, 2026

Copy link
Copy Markdown
Owner

And the options to turn it on is in the castbar menu? (Not home can't check)

@Reveax

Reveax commented May 27, 2026

Copy link
Copy Markdown
Author

Unless there's a different castbar menu, which I'm interpreting wrong. It can be found at "Appearence > Castbars > Interrupt Ready indicator" as an "Indicator Style" in the drop-down. Sorry if there might be an misunderstanding and thanks for the quick responses!

@Mapkov2

Mapkov2 commented May 27, 2026

Copy link
Copy Markdown
Owner

Yes there is under focus kick the last menu interrupt indicator and your version is basically just a different style. Instead of a border. Also keep in mind that glow effect might override your idea. So keep that also in mind

@Reveax Reveax force-pushed the feature/interrupt-unavailable-castbar-color branch from a894d15 to d9e68cb Compare May 27, 2026 08:47
@Reveax

Reveax commented May 27, 2026

Copy link
Copy Markdown
Author

Thanks for the headsup, i did some testing and glowis visible on player/preview, but target/focus castbars do not seem to visibly apply the glow fade even on a fresh install and profile, without my changes. The unavailable fill style follows the existing target/focus castbar color path, so it does not appear to introduce a new regression, but target/focus glow itself may already be limited/not visible.

Also rebased into 5.54 so its up to main

@Mapkov2

Mapkov2 commented May 27, 2026

Copy link
Copy Markdown
Owner

Yeah good. The Castbar won't be rewritten so will be easy to implement into 6.0 rewrite of UF/GF. Ty for contributing btw. Did you join the discord?

@Reveax

Reveax commented May 27, 2026

Copy link
Copy Markdown
Author

No worries, thanks for your amazing work! And yeah just joined the discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants