feat: add orthometric_height_offset support#26
Draft
rsasaki0109 wants to merge 6 commits intomainfrom
Draft
Conversation
rsasaki0109
changed the title
rsasaki0109
force-pushed
the
feature/add-vertical-datum-support
branch
from
60e935a to
6f8ce53
Compare
座標変換処理に工事基準面補正を適用: - LLHParam構造体にvertical_datum_offsetフィールドを追加 - 順変換（ELLIPS2ORTHO）で T.P. + offset = 工事基準面高さ を計算 - 逆変換（ORTHO2ELLIPS）で 工事基準面高さ - offset = T.P. を計算 - ジオイド補正後にオフセットを適用
Simplify the vertical datum implementation by using a single height_offset parameter instead of the complex vertical_datum enum approach (pdca2). Changes: - Rename vertical_datum_offset to height_offset in LLHParam struct - Update comments to Japanese for clarity - Remove bidirectional correction logic (keep only ELLIPS2ORTHO) - Add comprehensive test suite for height offset functionality This simpler approach allows users to directly specify offset values without maintaining preset enum values.
Align field name with YAML specification for construction reference plane offset parameter.
Update test file to use orthometric_height_offset field name.
rsasaki0109
force-pushed
the
feature/add-vertical-datum-support
branch
from
ed5920a to
0002b92
Compare
rsasaki0109
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
正標高変換時に高さオフセットを適用する機能を追加。荒川工事基準面（A.P.）等の工事基準面に対応。
Changes
llh_converter.hpp:LLHParam構造体にorthometric_height_offsetフィールド追加（デフォルト: 0.0）llh_converter.cpp:convertRad2XYZ()で ELLIPS2ORTHO 時のみオフセット適用height_offset_test.cpp: テストスイート追加Usage
Test plan