Open
Conversation
Collaborator
ofekazar
commented
Mar 7, 2026
ofekazar
commented
|
🎫 Related Jira Issue: MAPCO-9483 |
Collaborator
Author
|
Added UniTask as well so the animation runs as a UniTask instead of coroutine to match the main project way of doing things. |
ofekazar
force-pushed
the
MAPCO-9483-slider-toggle
branch
from
6af9755 to
4bb3f44
Compare
Assets/YahalomUIPackage/Runtime/YahalomSliderToggle/YahalomSliderToggle.cs
Outdated
Show resolved
Hide resolved
| { | ||
| public bool CurrentValue { get; private set; } | ||
|
|
||
| private bool _previousValue; |
Collaborator
There was a problem hiding this comment.
field is unnecessary
Comment on lines
+17
to
+20
| [Header("Animation")] | ||
| [SerializeField, Range(0, 1f)] private float animationDuration = 0.5f; | ||
| [SerializeField] | ||
| private AnimationCurve slideEase = |
Collaborator
There was a problem hiding this comment.
no animation in design
Collaborator
Author
There was a problem hiding this comment.
It's nicer with it
Collaborator
There was a problem hiding this comment.
but it is not in the design, we implement according to the design
Comment on lines
+8
to
+12
| namespace YahalomUIPackage.Runtime.YahalomSliderToggle | ||
| { | ||
|
|
||
| public class YahalomSliderToggle : Slider, IPointerClickHandler | ||
| { |
baruchInsert-tech
requested changes
Mar 9, 2026
Collaborator
baruchInsert-tech
left a comment
baruchInsert-tech
left a comment
There was a problem hiding this comment.
- import asset in 4x
- rename asset to knob
| { | ||
| serializedObject.Update(); | ||
|
|
||
| base.OnInspectorGUI(); |
Collaborator
There was a problem hiding this comment.
double serializedObject.Update() call, base.OnInspectorGUI() already calls serializedObject.Update() internally. call on line 31 is redundant.
ofekazar
force-pushed
the
MAPCO-9483-slider-toggle
branch
from
4bb3f44 to
5e8ac09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.