Added counter field with optional max value (MAPCO-9480)#32
Open
Added counter field with optional max value (MAPCO-9480)#32
Conversation
Collaborator
ofekazar
commented
Mar 6, 2026
ofekazar
commented
|
🎫 Related Jira Issue: MAPCO-9480 |
baruchInsert-tech
requested changes
Mar 8, 2026
Collaborator
There was a problem hiding this comment.
-
import assets 4x
-
rename assets to increase and decrease - not left add and right sub
-
rename to stepper - its the know term for this kind of components - like in the ticket
-
no hover state for increase and decrease buttons as wanted in the design
-
remove comments
ofekazar
force-pushed
the
MAPCO-9480-counter-field
branch
from
900aead to
44d6e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.