Skip to content

fix: update PolygonPartsProcessPayload to include shouldClearEntities #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razbroc merged 2 commits into from
Feb 2, 2026
Merged

fix: update PolygonPartsProcessPayload to include shouldClearEntities #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4749e5
fix: update PolygonPartsProcessPayload to include shouldClearEntities…
razbroc Feb 2, 2026
a3e1169
fix: correct indentation in polygonPartsManagerClient test for clarity
razbroc Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ export type CatalogUpdateMetadata = Partial<RasterLayerMetadata>;
//#endregion catalogClient

//#region PolygonPartsManagerClient
export type PolygonPartsProcessPayload = Pick<PolygonPartsPayload, 'productId' | 'productType' | 'jobType'>;
export type PolygonPartsProcessPayload = Pick<PolygonPartsPayload, 'productId' | 'productType'> & { shouldClearEntities?: boolean };
//#endregion PolygonPartsManagerClient

//#region seedingJobCreator
Expand Down
4 changes: 2 additions & 2 deletions src/job/models/ingestion/newJobHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export class NewJobHandler
activeSpan?.addEvent('layerNames.valid', { layerName });

if (!processedParts) {
const { type, resourceId, productType } = job;
await this.polygonPartsMangerClient.process({ jobType: type, productId: resourceId, productType });
const { resourceId, productType } = job;
await this.polygonPartsMangerClient.process({ productId: resourceId, productType });
finalizeTaskParams = await this.markFinalizeStepAsCompleted(job.id, task.id, finalizeTaskParams, 'processedParts');

activeSpan?.addEvent('processPolygonParts.success', { ...finalizeTaskParams });
Expand Down
4 changes: 2 additions & 2 deletions src/job/models/ingestion/swapJobHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ export class SwapJobHandler
const { tileOutputFormat, displayPath } = job.parameters.additionalParams;

if (!processedParts) {
const { type, resourceId, productType } = job;
const { resourceId, productType } = job;

await this.polygonPartsMangerClient.process({ jobType: type, productId: resourceId, productType });
await this.polygonPartsMangerClient.process({ shouldClearEntities: true, productId: resourceId, productType });
finalizeTaskParams = await this.markFinalizeStepAsCompleted(job.id, task.id, finalizeTaskParams, 'processedParts');

activeSpan?.addEvent('processPolygonParts.success', { ...finalizeTaskParams });
Expand Down
4 changes: 2 additions & 2 deletions src/job/models/ingestion/updateJobHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ export class UpdateJobHandler
activeSpan?.addEvent('layerNameFormat.valid', { layerName: layerNameFormats.layerName });

if (!processedParts) {
const { type, resourceId, productType } = job;
const { resourceId, productType } = job;

await this.polygonPartsMangerClient.process({ jobType: type, productId: resourceId, productType });
await this.polygonPartsMangerClient.process({ productId: resourceId, productType });
finalizeTaskParams = await this.markFinalizeStepAsCompleted(job.id, task.id, finalizeTaskParams, 'processedParts');

activeSpan?.addEvent('processPolygonParts.success', { ...finalizeTaskParams });
Expand Down
20 changes: 18 additions & 2 deletions tests/unit/httpClients/polygonPartMangerClient.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,24 @@ describe('polygonPartsManagerClient', () => {

const baseUrl = configMock.get<string>('servicesUrl.polygonPartsManager');
const payload: PolygonPartsProcessPayload = {
jobType: 'Ingestion_New',
productId: 'test_layer',
productType: RasterProductTypes.ORTHOPHOTO,
};
const url = '/polygonParts/process';
nock(baseUrl).put(url, payload).reply(200);

const action = polygonPartsManagerClient.process(payload);

await expect(action).resolves.toBeUndefined();
expect(nock.isDone()).toBe(true);
});

it('should process polygon parts and replacing old data successfully', async () => {
polygonPartsManagerClient = new PolygonPartsMangerClient(configMock, jsLogger({ enabled: false }));

const baseUrl = configMock.get<string>('servicesUrl.polygonPartsManager');
const payload: PolygonPartsProcessPayload = {
shouldClearEntities: true,
productId: 'test_layer',
productType: RasterProductTypes.ORTHOPHOTO,
};
Expand All @@ -43,7 +60,6 @@ describe('polygonPartsManagerClient', () => {

const baseUrl = configMock.get<string>('servicesUrl.polygonPartsManager');
const payload: PolygonPartsProcessPayload = {
jobType: 'Ingestion_New',
productId: 'test_layer',
productType: RasterProductTypes.ORTHOPHOTO,
};
Expand Down