feat!: mdr integration and deps update#28
Conversation
| export interface IMdrClient { | ||
| getStatus: () => Promise<EnrollmentStatus>; | ||
| postEnrollment: (enrollment: EnrollmentRequestBody) => Promise<void>; | ||
| } | ||
|
|
There was a problem hiding this comment.
Just use MdrClient class as a type. No need for separate interface
There was a problem hiding this comment.
Using interfaces as a type-safe option isn't redundant.
I find the explicit interface more readable, documented, type-safe, and less error-prone in future development.
InstanceType<typeof MdrClient> isn't as elaborate as a full interface.
| return (server: http.Server): http.Server => { | ||
| return createTerminus(server, { | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| healthChecks: { '/liveness': stubHealthcheck }, |
There was a problem hiding this comment.
Out of scope for this PR but, can we think of a real healthcheck?
There was a problem hiding this comment.
It is possible to check connectivity with the configured database, the problem is code-wise, we don't use a pg client but wrap the execution with osm2pgsql.
To have a proper healthcheck, we also need a pg client which takes and manages database connections, those are already a limited resource.
So today, if for any reason, the connection has gone bad, we will be notified once there is a job to be executed and the connection is off.
2 participants
Deprecations: k8s cronjob is no longer supported.