feat: added prefix option to redis#88
Merged
NatalieShaked merged 10 commits intomasterfrom Dec 25, 2025
Merged
Conversation
NivGreenstein
requested changes
Dec 24, 2025
config/default.json
Outdated
| "dbIndex": 0, | ||
| "ttl": 600 | ||
| "ttl": 600, | ||
| "prefix": "geocoding" |
Contributor
There was a problem hiding this comment.
Do we want it to use prefix by default?
If not, please remove.
you may enrich the docs instead
config/test.json
Outdated
| "dbIndex": 1 | ||
| "dbIndex": 1, | ||
| "ttl": 300, | ||
| "prefix": "test" |
Contributor
There was a problem hiding this comment.
it should check with and without prefix
| const { ttl: redisTtl } = this.config.get(redisConfigPath); | ||
|
|
||
| const originalJson = res.json; | ||
| const fullRequestId = prefix != undefined ? `${prefix}:${reqId as string}` : (reqId as string); |
Comment on lines
+95
to
+109
| describe('Redis uses prefix key', () => { | ||
| it('should return 200 status code and add key to Redis with prefix', async function () { | ||
| const config = depContainer.resolve<IConfig>(SERVICES.CONFIG); | ||
| const prefix = config.get<string | undefined>('redis.prefix'); | ||
| const redisConnection = depContainer.resolve<RedisClient>(SERVICES.REDIS); | ||
|
|
||
| const response = await requestSender.getTile({ tile: '18SUJ2339007393' }); | ||
|
|
||
| const keys = prefix !== undefined ? await redisConnection.keys(prefix + '*') : await redisConnection.keys('*'); | ||
|
|
||
| expect(keys.length).toBeGreaterThanOrEqual(1); | ||
|
|
||
| expect(response.status).toBe(httpStatusCodes.OK); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
manipulate the code to add prefix for this test only
NivGreenstein
requested changes
Dec 25, 2025
| > Feedback API source code is built in a different repository at <TODO: ADD LINK TO FEEDBACK API REPO>. | ||
| > Feedback API source code is built in a different repository at [feedback-api](https://github.com/MapColonies/feedback-api). | ||
| > Geocoding API inserts the request and response to Redis before the response is sent. | ||
| Speaking of Redis, in the redis config you can add a `prefix` flag, if you'd like to add keys with prefixes to redis. |
Contributor
There was a problem hiding this comment.
I think it should be somewhere else that is more relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further information:
Added the option to use prefix in Redis