Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR refactors the color_gradient method in core.py. It introduces two new parameters: transition_mode and blend_variation for the case when number_of_colors_provided = 1.
Motivation and Explanation: Why and how do your changes improve the library?
The code of color_gradient of main branch doesn't work as intended for the case when number of colors provided is 1. It returns back the same color, same brightness.
The PR makes it possible that when number of color provided is 1, then either the colors can be progressively lighter or darker as chosen, but the color itself will be of same hue. Also the brightness of successive colors can be varied using blend_variation. See the output below:
I used this code to test:
Here's the output of the main branch: All the squares have same colors and same brightness. That means no gradient at all. Since the method's name is color_gradient, the effect should have gradient.

Here's the output given by PR branch:

When transition_mode = "lighter". Each next square is lighter than the previous one.
When transition_mode = "darker". Each next square is darker than the previous one.

Reviewer Checklist