Skip to content

fix: fixes unit_size not working in Axes (#2336) and Surprising axis.__init__ default values (#2479) #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csoapyhands-gif wants to merge 6 commits into
base: main
Choose a base branch
from
+17 −5
Open

fix: fixes unit_size not working in Axes (#2336) and Surprising axis.__init__ default values (#2479) #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62f246a
fix: fixes unit_size not working in Axes
csoapyhands-gif Mar 20, 2026
2eb1da3
Delete my-project/manim.cfg
csoapyhands-gif Mar 20, 2026
5bdd0bc
Delete my-project/main.py
csoapyhands-gif Mar 20, 2026
340828c
Update file_ops.py
csoapyhands-gif Mar 20, 2026
ffb78ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 20, 2026
1b7963b
fix: ensure self.y_axis_config is used instead of y_axis_config
csoapyhands-gif Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions manim/mobject/graphing/coordinate_systems.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,8 +1932,8 @@ def __init__(
self,
x_range: Sequence[float] | None = None,
y_range: Sequence[float] | None = None,
x_length: float | None = round(config.frame_width) - 2,
y_length: float | None = round(config.frame_height) - 2,
x_length: float | None = None,
y_length: float | None = None,
axis_config: dict | None = None,
x_axis_config: dict | None = None,
y_axis_config: dict | None = None,
Expand Down Expand Up @@ -1989,6 +1989,16 @@ def __init__(
else:
self.y_axis_config["exclude_origin_tick"] = False

if "unit_size" in self.x_axis_config:
x_length = self.x_axis_config["unit_size"]
else:
x_length = round(config.frame_width) - 2

if "unit_size" in self.y_axis_config:
y_length = self.y_axis_config["unit_size"]
else:
y_length = round(config.frame_width) - 2

self.x_axis = self._create_axis(self.x_range, self.x_axis_config, self.x_length)
self.y_axis = self._create_axis(self.y_range, self.y_axis_config, self.y_length)

Expand Down
8 changes: 5 additions & 3 deletions manim/utils/deprecation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,11 @@ def foo(**kwargs):

@deprecated_params(
redirections=[
lambda buff=1: {"buff_x": buff[0], "buff_y": buff[1]}
if isinstance(buff, tuple)
else {"buff_x": buff, "buff_y": buff}
lambda buff=1: (
{"buff_x": buff[0], "buff_y": buff[1]}
if isinstance(buff, tuple)
else {"buff_x": buff, "buff_y": buff}
)
]
)
def foo(**kwargs):
Expand Down