[EXPERIMENTAL] Fix some graph tests#4569
Open
fmuenkel wants to merge 5 commits intoManimCommunity:experimentalfrom
Open
[EXPERIMENTAL] Fix some graph tests#4569fmuenkel wants to merge 5 commits intoManimCommunity:experimentalfrom
fmuenkel wants to merge 5 commits intoManimCommunity:experimentalfrom
Conversation
chopan050
requested changes
Feb 4, 2026
Contributor
chopan050
left a comment
There was a problem hiding this comment.
Thanks! I left some comments:
manim/mobject/graph.py
Outdated
Comment on lines
915
to
917
| if buf is not None and hasattr(buf, "replace"): | ||
| with contextlib.suppress(Exception): | ||
| buf.replace(v[-1]) |
Contributor
There was a problem hiding this comment.
I haven't been able to test this locally yet, but:
- Is the
hasattr(buf, "replace")check necessary? Ifbufis aSceneBuffer, it must already have areplace()method... - Why is
replace()used instead ofremove()? - What exceptions might happen by using this? Is it OK to suppress them?
Contributor
Author
There was a problem hiding this comment.
- Yes, I believe
hasattris redundant here. - So, this took me a while.
remove()did not work - it still left Dot and Line mobjects in scene.mobjects. I just happen to tryreplace()and it worked, but honestly, I don't understand the new rendering process well enough yet to figure out why. - I was thinking of cases like dry-run testing or if one of the mobjects was already removed. We don't want the run to fail, since the vertex was already created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Currently a lot of tests in
test_graph.pyfail, because__str__()is missing fromGraphandDiGraph.This PR
__str__()wrapping around__repr__()assert_allclose()to make two more test passgraph.py'sGenericGraph._add_vertices_animation()where not all temporary vertices were removed from the scenebuffer after the animation.Now all tests in
test_graph.pypass.Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist