Fix YELLOW_C and add PURE_CYAN, PURE_MAGENTA and PURE_YELLOW#4562
Open
chopan050 wants to merge 1 commit intoManimCommunity:mainfrom
Open
Fix YELLOW_C and add PURE_CYAN, PURE_MAGENTA and PURE_YELLOW#4562chopan050 wants to merge 1 commit intoManimCommunity:mainfrom
YELLOW_C and add PURE_CYAN, PURE_MAGENTA and PURE_YELLOW#4562chopan050 wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3579
As suggested by @yuan-xy, this PR changes
YELLOWandYELLOW_Cfrom#FFFF00to#F7D96Fin order to make them more consistent with the other shades of yellow.In order to not lose the original yellow, it has been renamed to
PURE_YELLOWin the same fashion asPURE_RED,PURE_GREENandPURE_BLUE. For extra consistency, this PR also addsPURE_CYANandPURE_MAGENTA.Here is the updated color table with the modified
YELLOW_Cand the extra three pure colors:Reviewer Checklist