[EXPERIMENTAL] Make play_logic and file_writer tests pass + Manager fixes#4559
Open
FBurna wants to merge 5 commits intoManimCommunity:experimentalfrom
Open
[EXPERIMENTAL] Make play_logic and file_writer tests pass + Manager fixes#4559FBurna wants to merge 5 commits intoManimCommunity:experimentalfrom
FBurna wants to merge 5 commits intoManimCommunity:experimentalfrom
Conversation
…ager interaction
…nd restore add_sound
- Fix Arrow stroke_width initialization (float vs list bug) and restore scaling logic. - Implement 'save_last_frame' logic by integrating it with skipping mechanism. - Refactor Manager.post_construct to ensure correct exit and image saving behavior. - Fix transparency issues in OpenGLRenderer (background_opacity and shader alpha). - Update shader code to use modern 'texture()' syntax instead of 'texture2D()'. - Fix VMobject recursion error in set_fill and ManimColor initialization. - Restore audio connectivity in Scene.add_sound. - Update tests to align with new Manager(Scene) architecture and document pending TODOs. - Detailed rationale in CHANGES_SUMMARY.md.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Hi! I've been working on getting the tests in
test_play_logic.pyandtest_file_writer.pyto pass reliably on the experimental branch. To do this, I had to fix several bugs and architecture issues that were getting in the way.Here is what I changed:
floatvslisttype error) and restored the scaling logic.save_last_frameactually work (mapped it to the new_skippinglogic).frozen_frameso time advances correctly even when mobjects don't update.dtcalculation to be smoother usingperf_counter.texture2Dfortexturein shaders (modern OpenGL).file_writertests (removed a line causing full opacity).VMobjectcolors.add_streaminstead of legacy template).Motivation and Explanation: Why and how do your changes improve the library?
Basically, I wanted to fix the test suite. The
play_logicandfile_writertests were largely broken or skipped, so I went down the rabbit hole of fixing theManagerandRendereruntil they passed.Now
test_file_writer.pypasses completely, andtest_play_logic.pyis stable (I marked one caching thing as a TODO because it needs more work).Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist