Skip to content

Small touch ups before fixing bugs with tip rendering #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josiest wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Small touch ups before fixing bugs with tip rendering #4503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions manim/mobject/geometry/arc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ def __init__(
self,
tip_length: float = DEFAULT_ARROW_TIP_LENGTH,
normal_vector: Vector3DLike = OUT,
tip_style: dict = {},
tip_style: dict | None = None,
**kwargs: Any,
) -> None:
self.tip_length: float = tip_length
self.normal_vector = normal_vector
self.tip_style: dict = tip_style
self.tip_style: dict = tip_style if tip_style is not None else {}
super().__init__(**kwargs)

# Adding, Creating, Modifying tips
Expand All @@ -129,7 +129,7 @@ def add_tip(
else:
self.position_tip(tip, at_start)
self.reset_endpoints_based_on_tip(tip, at_start)
self.asign_tip_attr(tip, at_start)
self.assign_tip_attr(tip, at_start)
self.add(tip)
return self

Expand Down Expand Up @@ -202,6 +202,9 @@ def position_tip(self, tip: tips.ArrowTip, at_start: bool = False) -> tips.Arrow
axis=axis,
) # Rotates the tip along the vertical wrt the axis
self._init_positioning_axis = axis

# TODO: The tip object should have its own local transform unaltered by its parent:
# Make the anchor point a group and shift that instead of the tip itself
tip.shift(anchor - tip.tip_point)
return tip

Expand All @@ -210,13 +213,15 @@ def reset_endpoints_based_on_tip(self, tip: tips.ArrowTip, at_start: bool) -> Se
# Zero length, put_start_and_end_on wouldn't work
return self

# TODO: the tip should only be able to position itself along the curve
# (potentially extending the curve) - it should not redefine the curve itself
if at_start:
self.put_start_and_end_on(tip.base, self.get_end())
else:
self.put_start_and_end_on(self.get_start(), tip.base)
return self

def asign_tip_attr(self, tip: tips.ArrowTip, at_start: bool) -> Self:
def assign_tip_attr(self, tip: tips.ArrowTip, at_start: bool) -> Self:
if at_start:
self.start_tip = tip
else:
Expand Down
Loading