-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add type annotations to mobject.py
#4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
953c07d
Add type annotations to `mobject.py`
henrikmidtiby 8c35540
More work on type annotations for mobject.py
henrikmidtiby be6d3ca
...
henrikmidtiby 7ce05ff
Almost handled all mypy errors
henrikmidtiby 4629173
Add the mypy error messages to the lines that trigger them
henrikmidtiby e80f22c
Use typing.cast to avoid some mypy errors, as suggested by JasonGrace…
henrikmidtiby e9e797e
Used the ruff linter
henrikmidtiby 8ec81a2
Fixed one typing issue and added the error descriptions to the source…
henrikmidtiby 3b39095
Set the type of the elements in a VGroup to VMobject
henrikmidtiby 0db274f
Use typing.cast to handle some specific cases.
henrikmidtiby 9f45342
Code cleaning
henrikmidtiby 4f21679
Updates
henrikmidtiby 43a8b47
When started to use typing.cast it is needed to import / define certa…
henrikmidtiby 0ec7b7b
Fix bug introduced with the type annotations.
henrikmidtiby bd41234
Made it work again
henrikmidtiby 2f8fbbb
..
henrikmidtiby f4d4066
Fixed more issues.
henrikmidtiby a55b1a9
Code cleanup
henrikmidtiby 31e5b8c
Code cleanup.
henrikmidtiby 4a5d55c
Handle slicing when accessing elements inside a VGroup
henrikmidtiby 92872ad
Fix missing issues.
henrikmidtiby 4f5d226
Silence the last mypy error
henrikmidtiby 4831707
Make _Updater, _NonTimeBasedUpdater and _TimeBasedUpdater private.
henrikmidtiby b82c0d8
Replace | with Union[...] in one location
henrikmidtiby 0ffe7f5
Move import of Union
henrikmidtiby f14e5c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1bc6893
Remove comment that is no longer relevant
henrikmidtiby bc5ab06
Overload the auto_zoom method in MovingCamera to provide better type …
henrikmidtiby 0ed7dcc
Codecleanup
henrikmidtiby edc8b8f
Code cleanup
henrikmidtiby 47643dc
Renamed lines_alignment to lines_alignments and added a TODO about a …
henrikmidtiby 470c8da
More code cleanup
henrikmidtiby 14c4c45
Update manim/mobject/matrix.py
henrikmidtiby 642a92d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9b41510
Addressing multiple comments from Chopan50
henrikmidtiby 658826a
Implementing more suggestions from Chopan50
henrikmidtiby e7f6f77
More suggestions by Chopan50
henrikmidtiby 2e85869
...
henrikmidtiby eafb1ac
More renaming and code cleanup, as suggested by Chopan50
henrikmidtiby 13c8c7d
Restructure code
henrikmidtiby 9371cdd
anim_args
henrikmidtiby 81014c9
Update typing in vector_space_scene
henrikmidtiby 8aa0b72
Implemented a number of suggestions from chopan50
henrikmidtiby 694d62d
Merge branch 'main' into TypingMobject
henrikmidtiby 4d6214a
Make a list of faces with the type list[ThreeDVMobject]
henrikmidtiby 4ffc91f
Ensure to return a VGroup if slicing is used.
henrikmidtiby 5894b7d
Revert back to the original code in text_mobject.py
henrikmidtiby b5bafdc
Merge branch 'main' into TypingMobject
henrikmidtiby 2cafe78
Merge branch 'main' into TypingMobject
chopan050 2f552c8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 751287b
Merge branch 'main' into TypingMobject
henrikmidtiby f1830f9
Add the propagate_colors option to Mobject as it is used by VMobject.
henrikmidtiby 0d2ad52
Simplify code
henrikmidtiby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / CodeQL
Statement has no effect