Skip to content

Conversation

@alxvth
Copy link
Contributor

@alxvth alxvth commented Jun 3, 2025

  • Move src/ScatterplotPlugin.json to ./PluginInfo.json
  • Add compatible core version to config file
  • Read plugin version from config file in cmake
  • Append plugin and core version to output library name
    • ScatterplotPlugin_p1.0.0_c1.4.0.dll on Windows
    • libScatterplotPlugin_p1.0.0_c1.4.0.dylib on Mac
    • libScatterplotPlugin_p1.0.0_c1.4.0.so on Linux

Depends on ManiVaultStudio/core#910, ManiVaultStudio/core#911


  • We could move the snippet that reads the plugin version from the config file into the core and install it as a cmake utility function. Then, it could only be called after find_package(ManiVault), but not each plugin had to repeat those lines.
  • I'm not sure about the core version entry in the plugin config file. We could keep it as a list, or name it coreMinVersion maybe. Either way, the library name will contain the core version that the plugin is build against.

@alxvth alxvth requested a review from ThomasKroes June 3, 2025 07:21
@alxvth alxvth marked this pull request as draft June 3, 2025 07:21
Copy link
Contributor

@ThomasKroes ThomasKroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small suggestion:

{
"name" : "Scatterplot View",
"version" : {
"plugin": "1.0.0",
"core": ["1.3"]
},
"dependencies" : ["Points"],
}

To me bundling version-related values makes a bit more sense.

@alxvth
Copy link
Contributor Author

alxvth commented Jun 3, 2025

I moved the config handling to the core, nested the versions and added an optional plugin type field to the config file.

The setup call mv_handle_plugin_config(${PROJECT}) now prints:

-- ManiVault plugin: Scatterplot View
--   version: 1.0.0
--   type: Viewer

@alxvth alxvth marked this pull request as ready for review June 3, 2025 10:17
@alxvth alxvth requested a review from ThomasKroes June 3, 2025 10:17
@alxvth alxvth merged commit 593673a into master Jun 4, 2025
10 checks passed
@alxvth alxvth deleted the feature/PluginConfigFile branch August 29, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants