-
Notifications
You must be signed in to change notification settings - Fork 1
Plugin config file #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin config file #176
Conversation
ThomasKroes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a small suggestion:
{
"name" : "Scatterplot View",
"version" : {
"plugin": "1.0.0",
"core": ["1.3"]
},
"dependencies" : ["Points"],
}
To me bundling version-related values makes a bit more sense.
|
I moved the config handling to the core, nested the versions and added an optional plugin type field to the config file. The setup call |
src/ScatterplotPlugin.jsonto./PluginInfo.jsonScatterplotPlugin_p1.0.0_c1.4.0.dllon WindowslibScatterplotPlugin_p1.0.0_c1.4.0.dylibon MaclibScatterplotPlugin_p1.0.0_c1.4.0.soon LinuxDepends on ManiVaultStudio/core#910, ManiVaultStudio/core#911
find_package(ManiVault), but not each plugin had to repeat those lines.I'm not sure about thecoreversion entry in the plugin config file. We could keep it as a list, or name itcoreMinVersionmaybe. Either way, the library name will contain the core version that the plugin is build against.