Updated Mangos.Extractor to support WoTLK and Cata. Credit to Brotalnia.#52
Closed
Daribon wants to merge 1 commit intoMangosServer:mainfrom
Closed
Updated Mangos.Extractor to support WoTLK and Cata. Credit to Brotalnia.#52Daribon wants to merge 1 commit intoMangosServer:mainfrom
Daribon wants to merge 1 commit intoMangosServer:mainfrom
Conversation
Contributor
|
Hi, Now we support only WoW 1.12.1. Do we need it? |
Collaborator
|
@Romfos Would be nice to have incase we upgrade to another version with this source. |
Contributor
Like main mangos, the Unified Extractor supports all versions of the core. |
Contributor
|
@Daribon There are a couple of issues which need resolving: |
|
This is pretty cool. I see that C# output was removed for C++. Why not make it possible to do either one by user choice? |
Contributor
|
Closing this is changes made and included in PR#71: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to WoTLK and Cataclysm to Mangos.Extractor. This means that the extractor supports all versions between 0.5.3 alpha to 4.3.4 cataclysm after it is applied.
Credit goes out to Brotalnia for most of the code in this commit. Brotalnia gave me permission to publish his code. I just updated the code to match the formatting and coding style of the latest revision, since it was based on an older revision.
The patch also changes the following:
As for the first lines in the commit with no changes, I think someone prior to this commit mixed up windows and unix line endings. I tried to filter it out as best as I could on commit.
This change is