Open
Conversation
MaksymKalennyk
requested changes
Oct 17, 2023
src/main/java/Generator.java
Outdated
Comment on lines
+13
to
+14
| System.out.println("Qr good"); | ||
| return 0; |
Owner
There was a problem hiding this comment.
вывод не нужен + что это за возвращение 0
src/main/java/GenerateQRCode.java
Outdated
Comment on lines
+11
to
+14
| public class GenerateQRCode { | ||
| public static void main(String[] args) throws WriterException, IOException { | ||
| String data="vova ukrainets 2"; | ||
| String path="/Users/volodimirukrainec/Desktop/qr/qr.jpg"; | ||
| BitMatrix matrix = new MultiFormatWriter().encode(data,BarcodeFormat.QR_CODE,500,500); | ||
|
|
||
| public static void main(String[] args) { | ||
| String data = "Kalennyk Maks 3"; | ||
| String path = "/Users/volodimirukrainec/Desktop/qr/qr.jpg"; |
Owner
There was a problem hiding this comment.
Этот класс у тебя чисто для проверки и он не нужен в этом пуллреквесте
Author
There was a problem hiding this comment.
для перевірки роботи класа? звідси ж береться інфа для кода і плебс де буде зберігатися картинка. я так розумію його видалити і потім вже додати бд відразу? чи що ти хоч побачити?
MaksymKalennyk
requested changes
Oct 17, 2023
src/main/java/Generator.java
Outdated
Comment on lines
+8
to
+9
| import java.nio.file.Paths; | ||
| public class Generator { |
Owner
There was a problem hiding this comment.
нужен пропуск + название класса не совсем точное
MaksymKalennyk
approved these changes
Oct 24, 2023
| MatrixToImageWriter.writeToPath(matrix, "JPG", Paths.get(path)); | ||
| System.out.println("Qr good"); | ||
| return 0; | ||
|
|
Owner
There was a problem hiding this comment.
лишний пропуск) но уже потом исправлю
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.