Fix setColor bug for whole ring color #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Fixed a few bugs such as MeRGBLed::setColor and MeEncoderOnBoard::setRatio. |
Ignore ir
…nition errors MeAuriga.h -> extern; add MeAuriga.cpp MeMegaPi.h/MeMegaPiPro.h -> extern arrays; add MeMegaPi.cpp, MeMegaPiPro.cpp MeMCore.h, MeBaseBoard.h, MeOrion.h, MeShield.h -> extern; add corresponding .cpp files Fixes ODR/linker issues when board headers are included by multiple .cpp files.
fix multiple definition error when including the main header into multiple classes.
Add MakeblockBoardConfig.h (board defaults and guards)
This reverts commit 5f95b6f.
…ePort and encoder_Port
Auriga Temp sensor
Accelerometer methods
Add ME_IR_DISABLE_ISR compile-time option to conditionally disable the MeIR interrupt handler, preventing linker errors when using buzzer/tone libraries that require the same AVR timer. Changes: - Wrap ISR(TIMER_INTR_NAME) with #ifndef ME_IR_DISABLE_ISR guard - Include new MeIR_config.h header for configuration - Document IR/Tone conflict and workaround in README - Bump version to 3.29.1 This allows users to disable the built-in IR receiver ISR when needed while maintaining backward compatibility by default.
feat(MeIR): add configurable ISR toggle to resolve timer conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the method
bool MeRGBLed::setColor(uint8_t index, long value)has a bug for index 0. The fix was only to change the affectation toifor thetmpvariable.