fix(dev): resolve Valkey image pull failure and clear server lint warnings

[ganeshwhere]

Summary

This PR fixes local DB startup failures in Docker and removes blocking lint warnings in the server codebase.

Problem

Running pnpm docker:db:up failed because the configured Valkey image could not be pulled:

• docker.io/bitnami/valkey:8.0: not found

Pre-commit checks were also failing due to eslint(no-unused-vars) warnings (treated as failures by oxlint --deny-warnings).

Root Cause

• docker-compose.db.yaml referenced a Valkey image/tag that was unavailable.
• apps/server/src/routes/chat.ts and apps/server/src/lib/email-verification.ts had unused imports, params, locals, and catch bindings.

Changes Made

• Updated Valkey image in docker-compose.db.yaml
  • from: docker.io/bitnami/valkey:8.0
  • to: bitnami/valkey:latest
• Cleaned apps/server/src/routes/chat.ts
  • removed unused imports/types and dead interface
  • removed unused locals
  • replaced unused catch params with catch {}
  • renamed unused method param to _options
• Cleaned apps/server/src/lib/email-verification.ts
  • replaced unused catch params with catch {}
  • simplified fallback handlers to .catch(() => false)

Validation

• pnpm docker:db:up
  • zerodotemail-db, zerodotemail-redis, zerodotemail-upstash-proxy all running
• pnpm dlx oxlint@1.9.0 --deny-warnings
  • Found 0 warnings and 0 errors.

Impact

• Fixes local Docker DB stack startup for Valkey.
• Restores clean pre-commit lint flow.
• No intended functional behavior changes beyond reliability/dev workflow fixes.

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• 💥 Breaking change (fix or feature with breaking changes)

Areas Affected

• Testing Infrastructure
• Development Workflow

Testing Done

• Manual testing performed

Security Considerations

• No sensitive data is exposed
• Authentication checks are in place
• Input validation is implemented

Checklist

• I have read the CONTRIBUTING document
• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in complex areas
• I have updated the documentation
• My changes generate no new warnings
• All tests pass locally

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.