Skip to content

Conversation

@Apricot-S
Copy link
Collaborator

Attributes listed in issue #84 were declared as class variables despite representing instance state.
They are now expressed as PEP 526 type annotations.

These attributes can no longer be accessed as class variables.
Normal usage should not rely on such access, but this is a breaking change for code that did.

@Apricot-S Apricot-S marked this pull request as ready for review January 24, 2026 13:42
@Apricot-S Apricot-S requested a review from Nihisil January 24, 2026 13:43
@Nihisil Nihisil merged commit 50d57de into MahjongRepository:master Jan 25, 2026
10 checks passed
@Apricot-S Apricot-S deleted the feat/remove-classvar branch January 25, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants