Skip to content

feat: Remove deprecated Yaku.english and Yaku.japanese properties #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nihisil merged 1 commit into from
Jan 24, 2026
Merged

feat: Remove deprecated Yaku.english and Yaku.japanese properties #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions mahjong/hand_calculating/yaku.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import warnings
from collections.abc import Collection, Sequence
from typing import Optional

Expand Down Expand Up @@ -38,13 +37,3 @@ def set_attributes(self) -> None:
Set id, name, han related to the yaku
"""
raise NotImplementedError

@property
def english(self) -> str:
warnings.warn("Use .name attribute instead of .english attribute", DeprecationWarning, stacklevel=2)
return self.name

@property
def japanese(self) -> str:
warnings.warn("Use .name attribute instead of .japanese attribute", DeprecationWarning, stacklevel=2)
return self.name