Skip to content

includes example for openai js sdk#323

Merged
NoamBenS merged 1 commit into
masterfrom
add-openai-sdk-js-example
Jun 1, 2026
Merged

includes example for openai js sdk#323
NoamBenS merged 1 commit into
masterfrom
add-openai-sdk-js-example

Conversation

@NoamBenS
Copy link
Copy Markdown
Contributor

No description provided.

@NoamBenS NoamBenS self-assigned this May 27, 2026
@NoamBenS NoamBenS marked this pull request as ready for review May 27, 2026 21:30
@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 27, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
promptlayer 🟢 Ready View Preview May 27, 2026, 9:31 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b02961887

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +55 to +56
modelSettings: {
reasoning: { summary: "auto" },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid sending reasoning settings for every model override

When users set OPENAI_MODEL to a non-reasoning model such as gpt-4o-mini or another supported Agents SDK model, this example still sends modelSettings.reasoning.summary, which the OpenAI model settings docs describe as model-dependent rather than universally supported. Because the README presents OPENAI_MODEL as a general optional override, those users can hit an API/runtime error before seeing any PromptLayer trace; gate these settings to known reasoning models or document/enforce that only reasoning-capable models are valid here.

Useful? React with 👍 / 👎.

@NoamBenS NoamBenS merged commit 2c58388 into master Jun 1, 2026
4 checks passed
@NoamBenS NoamBenS deleted the add-openai-sdk-js-example branch June 1, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants