Drop the Cython version check from setup.py#1314
Open
musicinmybrain wants to merge 1 commit intoMagicStack:masterfrom
Open
Drop the Cython version check from setup.py#1314musicinmybrain wants to merge 1 commit intoMagicStack:masterfrom
musicinmybrain wants to merge 1 commit intoMagicStack:masterfrom
Conversation
This avoids the dependency on the pkg_resources module, which has long been deprecated and is no longer shipped with current versions of setuptools.
bce6491 to
969376f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the dependency on the
pkg_resourcesmodule, which has long been deprecated and is no longer shipped with current versions ofsetuptools.The version check could have preserved by replacing
with
but then we would need to add a dependency on
packagingtobuild-system.requiresinpyproject.toml, and if we can trustbuild-system.requiresto give uspackaging, then we should be able to trust it to give us the correct version of Cython, too!