Update nextjs-page-transition to use runtime style injection#166
Update nextjs-page-transition to use runtime style injection#166michelle-dunson wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 0545ec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@claus are you able to review? |
|
@stevescavo @michelle-dunson What exactly was the problem? Do i need to know anything else to test this? Also, this is missing a changeset |
@claus Turbopack removes css too early and was causing hydration issues with page transitions. Injecting the styles in the head keeps the transitions styles active during transition. I have tested this within the library docs to confirm the styles apply and remain during transition, but I'll still need to test it within the bright-side page transition component. |
|
I'm still struggling to understand what is happening. Where did you run into this problem? I'd like to reproduce this. Those styles should never get removed. Maybe something weird happens in the |
|
@claus on bright-side after I upgraded next there were a bunch of css hydration issues because next 16 uses turbopack by default which was causing issues with page transition. I fixed it by just using the |
|
@claus do you have some time to review / collaborate on this? |
3 participants
Injects styles into head on mount rather than importing css module for Turbopack compatibility