Skip to content

feat: inventory full duplicate message fix #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JosTheDude wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: inventory full duplicate message fix #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7618be3
feat: inventory full duplicate message fix
JosTheDude May 27, 2026
570b518
chore: remove plugin version bump (req: maintainers)
JosTheDude May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/main/java/net/mackenziemolloy/shopguiplus/sellgui/command/CommandSellGUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ private void onGuiClose(Player player, InventoryCloseEvent event, Set<Integer> i

double totalPrice = 0;
int itemAmount = 0;
boolean excessItems = false;
List<ItemStack> droppedItems = new ArrayList<>();
boolean itemsPlacedInGui = false;

Inventory inventory = event.getInventory();
Expand Down Expand Up @@ -408,19 +408,17 @@ private void onGuiClose(Player player, InventoryCloseEvent event, Set<Integer> i
double amountSold2 = (totalSold2 + itemSellPrice);
moneyMap.put(itemEconomyType, amountSold2);
} else {
excessItems = true;

Location location = player.getLocation().add(0.0D, 0.5D, 0.0D);
Map<Integer, ItemStack> fallenItems = event.getPlayer().getInventory().addItem(i);
scheduler.runAtLocation(location, task -> {
World world = player.getWorld();
fallenItems.values().forEach(item -> world.dropItemNaturally(location, item));
});
droppedItems.addAll(fallenItems.values());
}
}

if (excessItems) {
if (!droppedItems.isEmpty()) {
sendMessage(player, "inventory_full");
Location location = player.getLocation().add(0.0D, 0.5D, 0.0D);
World world = location.getWorld();
scheduler.runAtLocation(location, task ->
droppedItems.forEach(item -> world.dropItemNaturally(location, item)));
}

if (totalPrice == 0) {
Expand Down