Sleep, Innovation, Weakness, and Reflection Summoner Skills

[ze-dom]

🚧 WIP 🚧

This is a follow-up on PR#477 from @bernatvadell . Used it as the basis.

To-do:

• Add comment references
• Update plugin

[gemini-code-assist]

Summary of Changes

Hello @ze-dom, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly overhauls the game's skill and magic effect system, with a particular focus on enhancing the Summoner class. It introduces a more sophisticated framework for defining and applying magic effects, allowing for separate PvP and PvM mechanics, variable durations based on target level, and chances of application. The changes also include new attributes for fine-tuning skill damage, a new 'asleep' status effect, and comprehensive database updates to support these new features. The aim is to provide greater depth and balance to character abilities and combat encounters.

Highlights

• Enhanced Magic Effect System: Introduced granular control over magic effects with new properties for chance, PvP-specific durations and power-ups, and target-level dependency for effect duration. This allows for more dynamic and balanced skill interactions.
• New Summoner Skills: Implemented three new Summoner skills: Sleep, Innovation, and Weakness. These skills now have distinct magic effects with configurable chances, durations, and impact on targets, including specific PvP/PvM variations.
• Refined Skill Damage Calculation: The damage calculation logic has been updated to incorporate new skill attributes like SkillBaseDamageBonus, SkillFinalDamageBonus, and SkillFinalMultiplier, providing more flexibility in defining skill damage formulas.
• New Status Effect: IsAsleep: A new IsAsleep attribute has been added, which prevents affected entities from moving or attacking, and is cleared upon taking damage. This introduces a new crowd control mechanic.
• RF Skill Multiplier Adjustments: Rage Fighter (RF) skill multipliers have been adjusted, and new skill-specific multipliers and bonus damage attributes have been introduced for various skills, including those related to elemental tomes.
• Database Schema Updates: New database migrations have been added to support the expanded MagicEffectDefinition and PowerUpDefinitionValue properties, ensuring persistence of the new skill and effect configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces new Summoner skills (Sleep, Innovation, Weakness) and includes a significant refactoring of the damage calculation system to enhance flexibility, particularly for PvP versus PvE scenarios. The changes are extensive, affecting data models, game logic, and persistence layers. Overall, the implementation is well-structured. I've identified a few issues, including a potential crash due to division by zero, a typo in an attribute description, and a bug in skill effect scaling logic. Addressing these points will improve the robustness and correctness of the new features.

[gemini-code-assist]

There's a potential DivideByZeroException here if magicEffectDefinition.PlayerTargetLevelDivisor or magicEffectDefinition.MonsterTargetLevelDivisor is set to 0. While the default is 1.0f, it's safer to guard against this case to prevent runtime crashes.

if (magicEffectDefinition.DurationDependsOnTargetLevel)
{
    var divisor = target is Player ? magicEffectDefinition.PlayerTargetLevelDivisor : magicEffectDefinition.MonsterTargetLevelDivisor;
    if (divisor != 0)
    {
        finalDuration -= target.Attributes[Stats.Level] / divisor;
    }
}

[gemini-code-assist]

The comment on line 110 indicates that the damage decrease scales with energy, but the code uses Stats.Level as the input attribute. This appears to be a copy-paste error and should likely be Stats.TotalEnergy.

decDmgPerEnergy.InputAttribute = Stats.TotalEnergy.GetPersistent(this.GameConfiguration);

[gemini-code-assist]

Similar to the PvE implementation, the comment on line 123 suggests scaling with energy, but the code uses Stats.Level. This should probably be Stats.TotalEnergy to align with the intended logic.

decDmgPerEnergyPvp.InputAttribute = Stats.TotalEnergy.GetPersistent(this.GameConfiguration);

[gemini-code-assist]

There's a typo in the description. "stome" should be "tome".

public static AttributeDefinition ExplosionBonusDmg { get; } = new(new Guid("543E01C2-5C61-4473-ACF9-8A63A987A230"), "Explosion Bonus Damage (MST)", "The explosion skill (book of samut) bonus damage, which rises with fire tome strengthener and is added at a late stage.");