Open
Conversation
jlammilliman
approved these changes
Nov 18, 2022
| }, | ||
| data() { | ||
| return { | ||
| isCompleted: this.done // TODO - Set this value dynamically |
There was a problem hiding this comment.
Can probably remove the Todo here. Reason being: 'done' will (I assume) be bound to the parent calling whatever instance this is referencing. So in the component here we can trust that this value will be reliable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a progress indicator component that can be reused throughout the app.
@blf885 As a good practice, when code reviewing, checkout the branch and run it locally. You'd typically want to try to break the feature by trying things from a browser (e.g. for a form entering different inputs, etc..). In this case, there isn't much to break.
In addition, look through all of the code files that were changed in this PR and you'd want to call out any issues or errors you see before approving (or if you can think of a much better way to do something).