Skip to content

[DOP-27550] docs(mddocs): add en docs from docs_rework#417

Open
annamikhailovapsk wants to merge 2 commits intodevelopfrom
feature/mddocs-en-folder
Open

[DOP-27550] docs(mddocs): add en docs from docs_rework#417
annamikhailovapsk wants to merge 2 commits intodevelopfrom
feature/mddocs-en-folder

Conversation

@annamikhailovapsk
Copy link

Change Summary

Created en folder documentation with documents in markdown

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/..rst file added describing change (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@github-actions
Copy link

Coverage

Coverage Report •
FileStmtsMissBranchBrPartCoverMissing
TOTAL7892971123221287% 
report-only-changed-files is enabled. No files were changed during this commit :)


- Create `openlineage.yml` file with content like:

```yaml title="KafkaTransport"
Copy link
Member

@dolfinus dolfinus Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В mkdocs есть вкладки? По идее это должны быть две вкладки для 2 вариантов интеграции, а не два блока с примерами друг за другом. А то люди запутаются...

.env.docker:1:5,23
--8<--

- Add scripts to crontab:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Наверное список из одного элемента не нужен

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А если это продолжение предыдущего списка, то он будет прерван блоком ###

Comment on lines +27 to +31
```yaml hl_lines="140-151" linenums="1"
----8<----
docker-compose.yml
----8<----
```
Copy link
Member

@dolfinus dolfinus Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```yaml hl_lines="140-151" linenums="1"
----8<----
docker-compose.yml
----8<----
```
----8<----
docker-compose.yml
----8<----

Оборачивать literal include в блок ``` неправильно. Проблема встречается больше одного раза

[debug][configuration-http2kafka-debug]

<!-- TODO: Check the place -->
<!-- ::: data_rentgen.http2kafka.settings.Http2KafkaApplicationSettings -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не совсем понятен текст TODO, тут что-то не работает?

Comment on lines +5 to +11
<!--
inherited_members: true
heading_[Incremental batch strategy][incremental-batch-strategy-0] 3
show_root_heading: true
-->

<!-- ## Http2Kafka Static Files -->
Copy link
Member

@dolfinus dolfinus Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот TODO и закомментированные блоки актуальны?

Comment on lines +5 to +10
<!-- TODO: include

```{raw} html
:file: ../../_static/swagger_http2kafka.html
```
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это актуально?

Comment on lines +17 to +18
```{eval-rst}
.. dropdown:: Interaction schema
Copy link
Member

@dolfinus dolfinus Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется тут достаточно обычного ```plantuml блока, а не eval-rst

This auth schema (not actually a AuthProvider) allows to access API endpoints using {ref}`personal-tokens`.
If enabled, it has higher priority than AuthProvider.

:::{note}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Синтаксис admonition точно правильный?

## Basic Configuration

```{eval-rst}
.. autopydantic_model:: data_rentgen.server.settings.auth.personal_token.PersonalTokenSettings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут кажется должен быть обычный ::: class

Firstly, install pre-commit hooks:

```bash
pre-commit install --install-hooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,20 @@
# Minimal makefile for Sphinx documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лишний файл

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Mar 26, 2026
@@ -0,0 +1 @@
If some run uses the same table as both input and output (e.g. merging duplicates or performing some checks before writing), DataRentgen excludes `dataset1 -> dataset1` relations from lineage with `granularity=DATASET`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Файлы в docs/changelog/next_release/*.rst удаляются при релизе, и превращаются в docs/changelog/$VERSION.rst. После конвертации остались и старые, и новые

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants