[DOP-34706] add indirect dependencies into job hierarchy request#416
Open
[DOP-34706] add indirect dependencies into job hierarchy request#416
Conversation
06e6ff3 to
73ab952
Compare
dolfinus
reviewed
Mar 25, 2026
dolfinus
reviewed
Mar 25, 2026
dolfinus
reviewed
Mar 25, 2026
dolfinus
reviewed
Mar 25, 2026
dolfinus
reviewed
Mar 26, 2026
Comment on lines
+149
to
+154
| @model_validator(mode="after") | ||
| def _check_indirect_flag(self): | ||
| if self.infer_from_lineage and not self.since: | ||
| msg = "Inferring from lineage graph only possible with 'since' param" | ||
| raise ValueError(msg) | ||
| return self |
Member
There was a problem hiding this comment.
Suggested change
| @model_validator(mode="after") | |
| def _check_indirect_flag(self): | |
| if self.infer_from_lineage and not self.since: | |
| msg = "Inferring from lineage graph only possible with 'since' param" | |
| raise ValueError(msg) | |
| return self | |
| @field_validator("since", mode="after") | |
| @classmethod | |
| def _check_since(cls, value: datetime | None, info: ValidationInfo) -> datetime | None: | |
| infer_from_lineage = info.data.get("infer_from_lineage") | |
| if infer_from_lineage and not value: | |
| msg = "'since' is mandatory when 'infer_from_lineage' is used" | |
| raise ValueError(msg) | |
| return value |
dolfinus
reviewed
Mar 26, 2026
|
|
||
|
|
||
| @pytest_asyncio.fixture | ||
| async def job_dependency_chain_with_indirect_dependencies( |
Member
There was a problem hiding this comment.
Suggested change
| async def job_dependency_chain_with_indirect_dependencies( | |
| async def job_dependency_chain_with_lineage( |
dolfinus
reviewed
Mar 26, 2026
Comment on lines
+484
to
+485
| - left_task -> task1 (indirect via input/output relation) | ||
| - task3 -> right_task (indirect via input/output relation) |
Member
There was a problem hiding this comment.
Suggested change
| - left_task -> task1 (indirect via input/output relation) | |
| - task3 -> right_task (indirect via input/output relation) | |
| - left_task -> task1 (inferred from via input/output relation) | |
| - task3 -> right_task (inferred from via input/output relation) |
dolfinus
reviewed
Mar 26, 2026
| @pytest.mark.parametrize( | ||
| ["direction", "depth", "start_node_idx", "expected_deps"], | ||
| [ | ||
| ("UPSTREAM", 1, 1, [(0, 1, "INFERRED_FROM_LINEAGE")]), |
Member
There was a problem hiding this comment.
Suggested change
| ("UPSTREAM", 1, 1, [(0, 1, "INFERRED_FROM_LINEAGE")]), | |
| pytest.param("UPSTREAM", 1, 1, [(0, 1, "INFERRED_FROM_LINEAGE")], id="indirect-upstream-depth-1"), |
IMHO it's more convenient than list of ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
GET /v1/jobs/hierarchyviainfer_from_lineage.since/untilbounds and validation (since < until, andinfer_from_lineagerequiressince).Related issue number
[DOP-34706]
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)