Update Check-UpdateComplianceSetting.ps1 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baardhermansen
commented
Dec 13, 2021
baardhermansen
commented
- Replaced the WMI calls with one call and use of a variable
- There were multiple logical errors in if statements. The if logic allowed both empty and non-empty values, effectively never reaching the else condition
- Switched to an easier method to check for empty string in if statements
- Corrected logical error in function CheckUtcCsp. It would report Passed if registry value did not exist.
- There were multiple logical errors in if statements. The if logic allowed both empty and non-empty values, effectively never reaching the else condition. Corrected all of them and also switched to a slightly easier method to check for empty string. - Corrected logical error in function CheckUtcCsp. It would report Passed if registry value did not exist.
Author
|
Review needed ;) @JankeSkanke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.