Minor updates to Python API following cmake #3232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- More use of None rather than empty string. - dwifslpreproc: Better handling of eddy options as list-of-strings. - More widespread support for pathlib.Path in API calls.
|
clang-tidy review says "All clean, LGTM! 👍" |
Lestropie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting draft PR to get minor tweaks out of my working directory to prioritise other things.
Found when trying to update a couple of external projects (bids-apps/MRtrix3_connectome#137, porting https://gist.github.com/Lestropie/aee5d9f13ba60dc34593df5e4ccf1125 from a Gist to an external project to replace #2400) that there were some annoying stumbling blocks in trying to use the API outside of the current set of commands. Will use this branch to collect any changes that expedite those external projects.