Skip to content

Variable-resolution gravity-wave absorbing layer formulation change #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skamaroc wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −8
Open

Variable-resolution gravity-wave absorbing layer formulation change #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core_atmosphere/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@
possible_values="Positive real values. A zero value implies that the length scale is prescribed by the nominalMinDc value in the input file."/>

<nml_option name="config_visc4_2dsmag" type="real" default_value="0.05"
units="-"
description="Scaling coefficient of $\delta x^3$ to obtain $\nabla^4$ diffusion coefficient"
units="ms^{-1}"
description="Coefficient multuplied by $\delta x^3$ to obtain $\nabla^4$ physical hyperviscosity"
possible_values="Non-negative real values"/>

<nml_option name="config_del4u_div_factor" type="real" default_value="10.0" in_defaults="false"
Expand Down Expand Up @@ -264,7 +264,7 @@
possible_values="Positive real values"/>

<nml_option name="config_xnutr" type="real" default_value="0.2"
units="-"
units="s^{-1}"
description="Maximum w-damping coefficient at model top"
possible_values="0 $\leq$ config_xnutr $\leq$ 1"/>

Expand Down
5 changes: 0 additions & 5 deletions src/core_atmosphere/mpas_atm_core.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,31 +1250,26 @@ subroutine atm_compute_damping_coefs(mesh, configs)
real (kind=RKIND), pointer :: config_xnutr, config_zd
real (kind=RKIND) :: z, zt, m1, pii
real (kind=RKIND), dimension(:,:), pointer :: dss, zgrid
real (kind=RKIND), dimension(:), pointer :: meshDensity
real (kind=RKIND) :: dx_scale_power

m1 = -1.0
pii = acos(m1)

call mpas_pool_get_dimension(mesh, 'nCells', nCells)
call mpas_pool_get_dimension(mesh, 'nVertLevels', nVertLevels)

call mpas_pool_get_array(mesh, 'meshDensity', meshDensity)
call mpas_pool_get_array(mesh, 'dss', dss)
call mpas_pool_get_array(mesh, 'zgrid', zgrid)

call mpas_pool_get_config(configs, 'config_zd', config_zd)
call mpas_pool_get_config(configs, 'config_xnutr', config_xnutr)

dx_scale_power = 1.0
dss(:,:) = 0.0
do iCell=1,nCells
zt = zgrid(nVertLevels+1,iCell)
do k=1,nVertLevels
z = 0.5*(zgrid(k,iCell) + zgrid(k+1,iCell))
if (z > config_zd) then
dss(k,iCell) = config_xnutr*sin(0.5*pii*(z-config_zd)/(zt-config_zd))**2.0
dss(k,iCell) = dss(k,iCell) / meshDensity(iCell)**(0.25*dx_scale_power)
end if
end do
end do
Expand Down