Fix sea ice time series cache functionality #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbegeman
changed the title
cbegeman
force-pushed
the
do-not-require-tseries-seaice-files-if-cached-output
branch
2 times, most recently
from
d4b6b77 to
fe3f005
Compare
cbegeman
force-pushed
the
do-not-require-tseries-seaice-files-if-cached-output
branch
from
fe3f005 to
5f8475d
Compare
xylar
reviewed
Dec 8, 2025
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
One suggested change. Otherwise, it looks great!
Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
Collaborator
Author
|
@xylar I'll leave it to you to merge and create the environment when you have a chance. |
Collaborator
TestingI ran the test suite as a sanity check and everything looks good: |
xylar
approved these changes
Dec 9, 2025
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
Great, thanks for making that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concatenate cache and new data for sea ice time series from the area-summed file, not the file with dimensions
nCells