Skip to content

Conversation

@cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented Dec 4, 2025

Check for transport output before loading input files

@cbegeman cbegeman requested a review from xylar December 4, 2025 22:17
@cbegeman
Copy link
Collaborator Author

cbegeman commented Dec 4, 2025

In testing E3SM-Project/zppy#760, we find that one additional change is needed to ensure transport time series can be generated from the cache.

@xylar
Copy link
Collaborator

xylar commented Dec 5, 2025

The Python 3.14 fail is expected, see #1127 (comment). Since I expect a fix in not too long, we could just disable python 3.14 in CI now and re-enable it in #1127. But I would prefer not to bother.

@xylar
Copy link
Collaborator

xylar commented Dec 5, 2025

I changed my mind. I'll drop it for now in #1129

@xylar xylar force-pushed the do-not-require-tseries-transport-files-if-cached-output branch from d38a60d to 236c5fa Compare December 5, 2025 10:09
@xylar
Copy link
Collaborator

xylar commented Dec 5, 2025

Testing

I ran the dev suite with thing branch and things work fine (the no_ncclimo and main_vs_ctrl tests are still running but no sign of trouble).

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/xasaydavis/analysis_testing/chrysalis/do-not-require-tseries-transport-files-if-cached-output/

@xylar xylar merged commit 3f7300a into MPAS-Dev:develop Dec 5, 2025
4 checks passed
@xylar
Copy link
Collaborator

xylar commented Dec 5, 2025

I realize I should have approved this formally. The changes are simple and make sense.

@cbegeman
Copy link
Collaborator Author

cbegeman commented Dec 5, 2025

@xylar Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants