feat : add aria label and replaced hardcoded colors#1034
Open
JoeMakuta wants to merge 2 commits intoMODSetter:devfrom
Open
feat : add aria label and replaced hardcoded colors#1034JoeMakuta wants to merge 2 commits intoMODSetter:devfrom
JoeMakuta wants to merge 2 commits intoMODSetter:devfrom
Conversation
… component for improved accessibility
|
@JoeMakuta is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 05030f6..71db2f8
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (2)
• surfsense_web/app/(home)/login/LocalLoginForm.tsx
• surfsense_web/components/tool-ui/audio.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audio Player Accessibility
Added dynamic [aria-label] to play/pause button that updates based on playback state:
aria-label={isPlaying ? "Pause" : "Play"}Added dynamic [aria-label] to mute button that updates based on mute state:
aria-label={isMuted ? "Unmute" : "Mute"}Theme Token Consistency in Login Form
Replaced hardcoded color utilities with semantic design tokens throughout the form
Motivation and Context
FIX #902
FIX #907
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR improves accessibility and design consistency by adding dynamic
aria-labelattributes to the audio player's play/pause and mute buttons (that update based on playback state), and replacing hardcoded color utilities in the login form with semantic design tokens (e.g.,destructive,primary,foreground,border) for better theme integration.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/tool-ui/audio.tsxsurfsense_web/app/(home)/login/LocalLoginForm.tsx