Skip to content

feat : add aria label and replaced hardcoded colors#1034

Open
JoeMakuta wants to merge 2 commits intoMODSetter:devfrom
JoeMakuta:feat/add-aria-label-and-replaced-hardcoded-colors
Open

feat : add aria label and replaced hardcoded colors#1034
JoeMakuta wants to merge 2 commits intoMODSetter:devfrom
JoeMakuta:feat/add-aria-label-and-replaced-hardcoded-colors

Conversation

@JoeMakuta
Copy link
Copy Markdown
Contributor

@JoeMakuta JoeMakuta commented Mar 29, 2026

Description

  1. Audio Player Accessibility
    Added dynamic [aria-label] to play/pause button that updates based on playback state: aria-label={isPlaying ? "Pause" : "Play"}
    Added dynamic [aria-label] to mute button that updates based on mute state: aria-label={isMuted ? "Unmute" : "Mute"}

  2. Theme Token Consistency in Login Form
    Replaced hardcoded color utilities with semantic design tokens throughout the form

Motivation and Context

FIX #902
FIX #907

Screenshots

API Changes

  • This PR includes API changes

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation
  • Dependency/Build system
  • Breaking change
  • Other (specify):

Testing Performed

  • Tested locally
  • Manual/QA verification

Checklist

  • Follows project coding standards and conventions
  • Documentation updated as needed
  • Dependencies updated as needed
  • No lint/build errors or new warnings
  • All relevant tests are passing

High-level PR Summary

This PR improves accessibility and design consistency by adding dynamic aria-label attributes to the audio player's play/pause and mute buttons (that update based on playback state), and replacing hardcoded color utilities in the login form with semantic design tokens (e.g., destructive, primary, foreground, border) for better theme integration.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_web/components/tool-ui/audio.tsx
2 surfsense_web/app/(home)/login/LocalLoginForm.tsx

Need help? Join our Discord

Analyze latest changes

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

@JoeMakuta is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@recurseml recurseml bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 05030f6..71db2f8

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (2)

surfsense_web/app/(home)/login/LocalLoginForm.tsx
surfsense_web/components/tool-ui/audio.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant