Implement Text input example use cases and e2e tests#226
Open
manyaagarwal wants to merge 3 commits intomlh-fellowship-migrated-ui-changesfrom
Open
Implement Text input example use cases and e2e tests#226manyaagarwal wants to merge 3 commits intomlh-fellowship-migrated-ui-changesfrom
manyaagarwal wants to merge 3 commits intomlh-fellowship-migrated-ui-changesfrom
Conversation
YashKumarVerma
approved these changes
Aug 18, 2020
manyaagarwal
changed the title
manyaagarwal
added
the
Final
* add documentationURL to example screens * remove community package screens * delete masked view iOS example
anku255
approved these changes
Aug 19, 2020
Member
anku255
left a comment
anku255
left a comment
There was a problem hiding this comment.
LGTM!
I have fixed the merge conflicts and also verified that the tests are passing. Here is the screenshot -
anku255
force-pushed
the
mlh-fellowship-migrated-ui-changes
branch
from
b7ebb69 to
b2d4f49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add use cases and e2e tests for all props in Textinput component
Changelog
iOSandandroidplatformpropertyTest Plan