Skip to content

Open source/feature/rviz display#69

Merged
ToniRV merged 18 commits intomasterfrom
open-source/feature/rviz_display
May 13, 2020
Merged

Open source/feature/rviz display#69
ToniRV merged 18 commits intomasterfrom
open-source/feature/rviz_display

Conversation

@ToniRV
Copy link
Copy Markdown
Collaborator

@ToniRV ToniRV commented May 12, 2020

  • Allow registration of different Visualizer and Display modules: this is so that ROS visualization plays nicely with Kimera:
  • Make Display and Visualizer of opencv inherit from base classes. (same for input/output packages).
    Swap modules upon user request
  • Separate Display.h into the opencv and its parent class (now they are in the same file).
  • Separate Visualizer.h into the opencv and its parent class ( now they are in the same file).

@ToniRV ToniRV mentioned this pull request May 12, 2020
2 tasks
@violetteavi
Copy link
Copy Markdown
Contributor

Note: This branch breaks at compile time with current Kimera-VIO-ROS master with this error:

/home/andrew/catkin_ws/src/Kimera-VIO-ROS/src/RosDataProviderInterface.cpp: In member function ‘virtual bool VIO::RosDataProviderInterface::publishSyncedOutputs()’:
/home/andrew/catkin_ws/src/Kimera-VIO-ROS/src/RosDataProviderInterface.cpp:226:45: error: ‘visualizeMesh2D’ is not a member of ‘VIO::Visualizer3D’
         cv::Mat mesh_2d_img = Visualizer3D::visualizeMesh2D(

It does compile with this Kimera-VIO-ROS branch. I will run a manual test on the two branches using the RealSense IR dataset and report back.

@ToniRV ToniRV merged commit 5a91df2 into master May 13, 2020
@ToniRV ToniRV deleted the open-source/feature/rviz_display branch May 13, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants