Fix ingester DB cache eviction/export safety and startup cleanup#10
Closed
ian-ross wants to merge 9 commits into
Closed
Fix ingester DB cache eviction/export safety and startup cleanup#10ian-ross wants to merge 9 commits into
ian-ross wants to merge 9 commits into
Conversation
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
Co-authored-by: GPT-5.3 Codex Spark <openai-codex-gpt-5.3-codex-spark@pi.local> Pi-Model: openai-codex/gpt-5.3-codex-spark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PR #9 had post-review correctness gaps around data-loss risk and fail-open behavior during staging export/import. This PR addresses those before merging the ingester isolation work.
Changes
P1: Prevent uncommitted touched DB evictions
_evict_staged_connectionsnow loops while over cache limit and for touched candidates:P2: Fail-fast staging export connection behavior
_open_raw_staging_connectionnow raisesRuntimeErroron read-only open failure instead of falling back to read-write.P3: Resource/cleanup hardening
scratch/ingester-exportnow removes only*.export.*.sqlitefiles, preserving unrelated scratch artifactsTests
uv run --python 3.13 pytest tests/feder_ingest/test_db_cache_paths.py -q