-
Notifications
You must be signed in to change notification settings - Fork 20
SMIT CT Lung GTV segmentation model #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LennyN95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🚀
- Can we avoid using conda and instead install all requirements with uv? Our base image comes with uv installed and a virtual environment set-up. However, it is suggested that you create your own virtual environment with uv, e.g.,
uv venv -p 3.10 .venv310 - The contents of the
meta.jsonare used to populate the model card on our website under mhub.ai/models. The more information, the better. - To test-build the model and to move forward with our test routine, an mhub.toml file needs to be created.
|
@LennyN95 Thank you for the in-depth feedback! We're working to address the suggestions. I have an additional question: when we upload our test data to Zenodo (for the mhub.toml), should we refer to the mHub DOI# 13785615 or create a new DOI from an independent/new entry? |
|
I would recommend renaming the PR to "SMIT CT Lung GTV segmentation model" (or something similar). |
|
You're more than welcome. Thank you and your team for the great work.
@locastre We mainly use Zenodo for it's reproducible storage mechanism, so you can create a new DOI for your sample & reference. |
|
@locastre FYI; There are also some errors in the compliance check that need to be resolved:
|
|
@LennyN95 Hopefully we're ready for your review; we've addressed your feedback and tested the model within the mHub framework. Thanks for your help with this process. |
|
Thank you Jue for the great work! Unfortunately, the test failed due to what looks like a GPU incompatibility (see below). We use NVIDIA RTX A6000 GPU for testing and so far all models worked fine - can you have a look? Ideally we can find a solution that applies to a wide range of customer hardware. |
|
@LennyN95 Hi Lenny, I added an explicit install command for |
Test Resultsid: aa683d35-ae95-4dd2-bdb9-4c7bc81cfe9c
name: MHub Test Report (default)
date: '2025-04-23 09:37:41'
missing_files:
- seg.dcm
extra_files:
- 1.3.6.1.4.1.14519.5.2.1.1.11635178980898764572976586249071182079/smit.seg.dcm
summary:
files_missing: 1
files_extra: 1
checks: {}
conclusion: false
|
|
Thank you @locastre. The model now runs, we're almost there! The test is still failing, because the reference data doesn't match with the model output (see report). Please make sure, that the reference data looks like: You can follow the steps here to prepare the output for the test procedure. To increase the usability, could you change the filename from |
|
@LennyN95 thanks for the catch. I've updated the data in the test zip and renamed the output SEG to |
Test Resultsid: d5b328ee-037e-4909-9827-65e6e1c31a67
name: MHub Test Report (default)
date: '2025-04-23 19:08:01'
checked_files:
- file: msk_smit_lung_gtv.seg.dcm
path: /app/data/output_data/1.3.6.1.4.1.14519.5.2.1.1.11635178980898764572976586249071182079/msk_smit_lung_gtv.seg.dcm
checks:
- checker: DicomsegContentCheck
notes:
- label: Segment Count
description: The number of segments identified in the inspected dicomseg file.
info: 1
summary:
files_missing: 0
files_extra: 0
checks:
DicomsegContentCheck:
files: 1
conclusion: true
|
|
@locastre Amazing, we now passed all tests - yay! Thank you for the great work! |
|
|
|
@locastre, perfect! I have one last request that I initially overlooked. Could you add the sample annotation to the default.yaml workflow? This addition will help our users understand how the input and output data are organized. It also gives us a chance to explain the role of each file and folder, which is quite self-explanatory in the case of DICOM. This is a fairly new feature I added, and we are gradually rolling it out for all legacy models as well. You can look at this model for more examples. |
|
@LennyN95 |
|
@locastre The model is now online. Amazing work!! FYI; I shortened the title to |

Submitting the SMIT CT Lung GTV segmentation model for mHub