Skip to content

Conversation

@MarvinFischer
Copy link
Contributor

Description of changes

  • Changed the Dialog Base to use a fixed size. Add the parameter fullWidth as Property and as CssClass.
  • Added helper Makefile for linux developers
  • removed the scrollbar of subactions of the editing content modal

Screenshots show changes:

Change-3 Change-2

How has this been tested?

Please describe the test strategy you followed.

  • automated unit test
  • automated integration test
  • automated acceptance test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

  • My code follows the coding guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code fulfilles all acceptance criteria
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have added explanation of architectural decision and rationales to wiki/adr
  • I have updated the changes in the ticket description

Checklist for reviewer

  • The code works and does not throw errors
  • The code is easy to understand and there are no confusing parts
  • The code follows the coding guidelines of this project
  • The code change accomplishes what it is supposed to do
  • I cannot think of any use case in which the code does not behave as intended
  • The added and existing tests reasonably cover the code change
  • I cannot think of any test cases, input or edge cases that should be tested in addition
  • Description of the change is included in the documentation

@MarvinFischer MarvinFischer changed the base branch from main to dev September 18, 2025 14:46
@MarvinFischer MarvinFischer mentioned this pull request Sep 18, 2025
21 tasks
Copy link
Contributor

@ZiyaSelim ZiyaSelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one small error and the linting/prettier jobs failing the rest works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants