Fix #3743: Modernize deprecated test assertions in hydrogen bond tests

[ShivansGupta25]

Summary

Modernize test assertions in test_hydrogenbonds_analysis.py by replacing deprecated NumPy testing helpers with current testing practices.

Changes

• Removed unused assert_almost_equal import.
• Replaced assert_almost_equal assertions with more appropriate modern alternatives.
• Replaced floating-point comparisons with numpy.testing.assert_allclose where applicable.
• Preserved existing test behavior and tolerances.
• Updated assertions to better match the type of values being tested.

Testing

pytest testsuite/MDAnalysisTests/analysis/test_hydrogenbonds_analysis.py -q

Result:

79 passed

AI Declaration

• I used AI assistance while working on this PR.

AI was used for:

• Understanding the issue requirements.
• Identifying deprecated testing patterns.
• Suggesting modern assertion alternatives.
• Reviewing proposed test changes.

All suggested changes were manually reviewed, verified, and tested by me before submission.

[IAlibay]

@ShivansGupta25 Thanks for opening this PR. However, before we can review we ask you put back and answer the AI declaration which was the in the PR template.

[IAlibay]

Blocking until relevant declarations are added back into the PR description.

[ShivansGupta25]

@ShivansGupta25 Thanks for opening this PR. However, before we can review we ask you put back and answer the AI declaration which was the in the PR template.

I've restored and completed the AI declaration section. All changes were reviewed and tested locally. Thanks for pointing it out sir.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.85%. Comparing base (941d679) to head (2000ebb).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5400   +/-   ##
========================================
  Coverage    93.85%   93.85%           
========================================
  Files          182      182           
  Lines        22509    22509           
  Branches      3202     3202           
========================================
  Hits         21125    21125           
  Misses         922      922           
  Partials       462      462           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.