Fix compatibility for binary operations #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 87.60% 87.70% +0.09%
==========================================
Files 5 5
Lines 742 748 +6
Branches 96 97 +1
==========================================
+ Hits 650 656 +6
Misses 56 56
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orbeckst
requested changes
Dec 8, 2025
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Looking all good.
Please also
- add yourself to AUTHORS
- update CHANGES
- bumped next release to 1.1.0 because this PR contains enhancements - sorted entries for CHANGELOG
orbeckst
approved these changes
Dec 9, 2025
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
All looking good, thank you for your contribution.
This will go into a new 1.1.0 release.
Member
|
Thank you @ollyfutur ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Binary operations on two
Gridobjects with differentedgesparameters should raise aTypeErroras stated in the docstring ofGrid.check_compatible.This pull request implements the expected behavior, and also allows operations with non-Grid objects that are broadcastable to the
Grids shape, such asnumpy.ndarray. This is why I removed the testsince the string
"foo"is broadcastable to any array shape, it does not raise incheck_compatible(an error will probably be raised downstream anyways for any such operation).I also modified the docstrings accordingly and added a couple of tests.