Skip to content

Fix a crashing issue when toggling fullscreen mode #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mynameisbob1928 wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −3
Open

Fix a crashing issue when toggling fullscreen mode #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/me/cortex/voxy/client/core/NormalRenderPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,11 @@ protected int setup(Viewport<?> viewport, int sourceFB, int srcWidth, int srcHei
this.colourTex = new GlTexture().store(GL_RGBA8, 1, viewport.width, viewport.height);
this.colourSSAOTex = new GlTexture().store(GL_RGBA8, 1, viewport.width, viewport.height);

this.fb.framebuffer.bind(GL_COLOR_ATTACHMENT0, this.colourTex).verify();
this.fbSSAO.bind(this.fb.getDepthAttachmentType(), this.fb.getDepthTex()).bind(GL_COLOR_ATTACHMENT0, this.colourSSAOTex).verify();
this.fb.framebuffer.bind(GL_COLOR_ATTACHMENT0, this.colourTex);
this.fbSSAO.bind(this.fb.getDepthAttachmentType(), this.fb.getDepthTex()).bind(GL_COLOR_ATTACHMENT0, this.colourSSAOTex);

this.fb.framebuffer.verify();
this.fbSSAO.verify();


glTextureParameterf(this.colourTex.id, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/me/cortex/voxy/client/core/rendering/util/DepthFramebuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public boolean resize(int width, int height) {
this.depthBuffer.free();
}
this.depthBuffer = new GlTexture().store(this.depthType, 1, width, height);
this.framebuffer.bind(this.getDepthAttachmentType(), this.depthBuffer).verify();
this.framebuffer.bind(this.getDepthAttachmentType(), this.depthBuffer);
return true;
}
return false;
Expand Down