Add telemetry opt-out via DO_NOT_TRACK and MCPJAM_TELEMETRY_DISABLED env vars#1546
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughTwo telemetry documentation blocks were added to Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@sdk/src/telemetry.ts`:
- Around line 7-17: The noopPosthog object has a capture signature with no args
which causes the exported posthog to have an incompatible union type; update
noopPosthog so its method signatures match PostHog's API (e.g., change capture
to accept the same EventMessage parameter, and ensure flush/shutdown match
PostHog types), import or reference PostHog/EventMessage types and type-annotate
noopPosthog (or cast noopPosthog as PostHog) so the exported posthog variable
has a consistent PostHog-compatible type rather than PostHog | typeof
noopPosthog.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2ca44975-0803-4fa9-923e-733b3582e997
📒 Files selected for processing (2)
sdk/README.mdsdk/src/telemetry.ts
|
Thanks @ignaciojimenezr ! |
|
of course! |
Closes #1544