Conversation
jeremy-brooks-1
added
the
Albany
|
Requires Albany changes in: sandialabs/Albany#1101 |
jeremy-brooks-1
force-pushed
the
jeremy-brooks-1/mali/debris-friction-full
branch
2 times, most recently
from
c924550 to
079213d
Compare
| <var name="bulkFriction" type="real" dimensions="nCells Time" default_value="0.0" | ||
| description="input value of bulk friction coefficient in debris-bed friction sliding law." | ||
| /> | ||
| <var name="basalDebrisFactor" type="real" dimensions="nCells Time" units="Pa yr m^-1" default_value="0.0" |
There was a problem hiding this comment.
@mperego , are these the correct units we should use here? Do we need to account for any scaling that Albany does here? (noting that I'm not sure if Jeremy had implemented scaling on these fields on the Albany side)
There was a problem hiding this comment.
Based on how they are used in Albany, I think bedRoughnessRC is fine, but basalDebrisFactor should be in kPa yr m^{-1}, like muFriction. We can convert the unis in the interface_velocity_solver.cpp file.
This commit adds a new edRoughnessRC variable to MALI on the MPAS side. Corresponding changes are needed on the Albany side.
Adding two fields (bulkFriction, basalDebris) to use with debris-bed friction slip law.
Updated Registry and MPAS velocity interface
mperego
force-pushed
the
jeremy-brooks-1/mali/debris-friction-full
branch
from
4b67208 to
28ada67
Compare
TestingI confirmed when testing with the following hashes that all expected tests pass the full_integration suite. This however, does not test the new feature so that will be addressed in a separate comment. |
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
Approving based on testing by @jeremy-brooks-1 , @mperego , and the new compass test case I created: MPAS-Dev/compass#938
3 participants
This PR implements the debris-bed friction slip law, which adds two sources of debris-bed friction to the regularized Coulomb relation. It uses two debris friction coefficients
bulkFrictionandbasalDebris.Albany changes are located here: sandialabs/Albany#1184
Testing of this slip law with MISMIP+ is located here: MPAS-Dev/compass#938