fix: deploy GitHub Pages from master branch#130
Closed
sujen1412 wants to merge 4 commits into
Closed
Conversation
Add Comprehensive Sphinx-Compatible Documentation
docs: add PyPI installation instructions
The deploy job only triggered on refs/heads/main, but the repo's default branch is master. Added master to push/PR triggers and the deploy condition so Pages actually deploys.
Contributor
Author
|
Closing this to rebase from develop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterto thepushandpull_requestbranch triggers — the workflow was only watchingmainanddevelop, so pushes tomasternever triggered itrefs/heads/master— the deploy job was gated onrefs/heads/mainexclusively, so no deployment ever ranRoot cause
The repo's default branch is
master, but the workflow was written formain. GitHub Pages showedstatus: null(never deployed) as a result.Test plan
Build Documentationworkflow should trigger on themasterpush and the deploy job should run, publishing to https://maap-project.github.io/maap-py/